[crac] RFR: 8364538: [CRaC] Test CRaCIgnoreRestoreIfUnavailable [v4]

Timofei Pushkin tpushkin at openjdk.org
Thu Aug 7 06:22:36 UTC 2025


On Tue, 5 Aug 2025 10:07:46 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:

>> Adds tests for `CRaCIgnoreRestoreIfUnavailable`.
>> 
>> The case for incompatible CPU features is not tested, although I believe it should work. Such test would be more complex (to the best of my knowledge, emulation is needed to be able to reduce the set of available features between checkpoint and restore) so it deserves a separate task. It would be something like what `test/jdk/jdk/crac/CPUFeatures/CPUFeatures.sh` does (have never run it, not sure if it works).
>
> Timofei Pushkin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Run NoCPUFeaturesTest only on Linux

Thank you for the review.

I believe it is only `EngineFailureTest.java` you don't like but yes, I don't see ways to improve it until we add a library-based engine to OpenJDK.

-------------

PR Comment: https://git.openjdk.org/crac/pull/255#issuecomment-3162662694


More information about the crac-dev mailing list