[crac] RFR: 8364449: [CRaC] Launch new main outside of the core C/R body [v2]

Timofei Pushkin tpushkin at openjdk.org
Thu Aug 7 08:37:05 UTC 2025


On Thu, 7 Aug 2025 06:48:00 GMT, Radim Vansa <rvansa at openjdk.org> wrote:

>> Timofei Pushkin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add missing space
>
> test/jdk/jdk/crac/newArgs/CheckpointInNewMainTest.java line 59:
> 
>> 57:         final var out = builder.doRestore().outputAnalyzer();
>> 58: 
>> 59:         out.shouldContain(RESTORE_OLD_MSG).shouldContain(RESTORE_NEW_MSG);
> 
> I think that a common pattern is to suppress continuation of the old main. Could you call add a variant that calls `System.exit(0)` in `InternalMain` and assert that `RESTORE_OLD_MSG` is not printed in that case?

Added this to `FailedCheckpointRestoreTest` — felt a bit more appropriate since it tests various points at which execution ends. Although the clearest way would be to add a separate test...

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/253#discussion_r2259543430


More information about the crac-dev mailing list