[crac] RFR: 8364449: [CRaC] Launch new main outside of the core C/R body [v2]
Timofei Pushkin
tpushkin at openjdk.org
Thu Aug 7 08:57:29 UTC 2025
On Thu, 7 Aug 2025 06:54:02 GMT, Radim Vansa <rvansa at openjdk.org> wrote:
>> Timofei Pushkin has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Add missing space
>
> test/jdk/jdk/crac/newArgs/FailedCheckpointRestoreTest.java line 52:
>
>> 50:
>> 51: public enum Variant {
>> 52: SUCCESS,
>
> The `SUCCESS` variant looks identical to `CheckpointInNewMainTest`, except for registering a resource that wouldn't do anything. Could you merge these?
Removed this but it basically got moved to `ExitFromNewMainTest` with false as an argument. I just think that even though `CheckpointInNewMainTest` currently does test this its purpose is different (to test calling checkpoint in the new main) so it may eventually change and stop testing this (e.g. we may add `System.exit()` to it for some reason).
-------------
PR Review Comment: https://git.openjdk.org/crac/pull/253#discussion_r2259612291
More information about the crac-dev
mailing list