[crac] RFR: 8364554: [CRaC] Improve CRaC VM options' docs [v4]

Radim Vansa rvansa at openjdk.org
Fri Aug 8 11:42:39 UTC 2025


On Tue, 5 Aug 2025 07:36:57 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:

>> src/hotspot/share/runtime/globals.hpp line 1969:
>> 
>>> 1967:                                                                             \
>>> 1968:   product(uint, CRaCMinPid, 128,                                            \
>>> 1969:           "Mininal PID value for checkpointed process (Unix only)")         \
>> 
>> `Unix` -> `POSIX` (same as in java.md). Linux is not Unix.
>
> I agree but I am following the style of the file. In this file "(Unix only)" is used for 3 other options while "posix" is not used at all.

Understood, but that doesn't make it correct. Linux is still not Unix. Btw., should we move this to `globals_linux.hpp`?

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/256#discussion_r2262713840


More information about the crac-dev mailing list