[crac] RFR: 8364554: [CRaC] Improve CRaC VM options' docs [v4]
Timofei Pushkin
tpushkin at openjdk.org
Fri Aug 8 12:43:22 UTC 2025
On Tue, 5 Aug 2025 09:48:58 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:
>> Timofei Pushkin has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix CRaCSkipCheckpoint aliasing
>
> src/hotspot/share/runtime/arguments.cpp line 1:
>
>> 1: /*
>
> BTW maybe it is time to put expiration dates for all of CRaC's deprecated/obsoleted options? For each parsed argument there are linear searches through lists of special (deprecated/obsoleted/expired) and aliased flags `strcmp`-ing them which slows down argument parsing.
>
> Since most of them have been deprecated since winter we can put 26 as the expiration version: it will be a year since the options were deprecated. For the ones deprecated/obsoleted today it can be 27.
Ended up expiring everything since 26: the options added to special in this PR are diagnostic/experimental and not widely used, so this is in accordance with OpenJDK's recommendations.
-------------
PR Review Comment: https://git.openjdk.org/crac/pull/256#discussion_r2262869028
More information about the crac-dev
mailing list