[crac] Integrated: 8364456: [CRaC] Extend error logging of waitForCheckpointed

[Timofei Pushkin]

On Thu, 31 Jul 2025 17:59:56 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:

> Makes `CracProcess.waitForCheckpointed()` print the same logs as `CracProcess.waitForSuccess()` does.
> 
> <details>
> 
> <summary>Before</summary>
> 
> 
> STDERR:
> Starting process to be checkpointed:
> <crac-repo>/build/linux-arm64-slow-openjdk/images/jdk/bin/java -ea -XX:CRaCEngine=criuengine -cp <crac-repo>/build/linux-arm64-slow-openjdk/test-support/jtreg_test_jdk_jdk_crac_newArgs_CheckpointInNewMainTest_java/classes/0/jdk/crac/newArgs/CheckpointInNewMainTest.d:<crac-repo>/build/linux-arm64-slow-openjdk/test-support/jtreg_test_jdk_jdk_crac_newArgs_CheckpointInNewMainTest_java/classes/0/test/lib -XX:CRaCEngineOptions=direct_map=false -XX:CRaCCheckpointTo=cr jdk.test.lib.crac.CracTest __run_test__ CheckpointInNewMainTest
> java.lang.RuntimeException: Checkpointed process was not killed as expected. expected: 137 but was: 1
>         at jdk.test.lib.Asserts.fail(Asserts.java:715)
>         at jdk.test.lib.Asserts.assertEquals(Asserts.java:208)
>         at jdk.test.lib.crac.CracProcess.waitForCheckpointed(CracProcess.java:41)
>         at jdk.test.lib.crac.CracBuilder.doCheckpoint(CracBuilder.java:241)
>         at CheckpointInNewMainTest.test(CheckpointInNewMainTest.java:53)
>         at jdk.test.lib.crac.CracTest.run(CracTest.java:163)
>         at jdk.test.lib.crac.CracTest.main(CracTest.java:90)
>         at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
>         at java.base/java.lang.reflect.Method.invoke(Method.java:565)
>         at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:335)
>         at java.base/java.lang.Thread.run(Thread.java:1474)
> 
> JavaTest Message: Test threw exception: java.lang.RuntimeException
> JavaTest Message: shutting down test
> 
> 
> </details>
> 
> <details>
> 
> <summary>After</summary>
> 
> 
> STDERR:
> Starting process to be checkpointed:
> <crac-repo>/build/linux-arm64-slow-openjdk/images/jdk/bin/java -ea -XX:CRaCEngine=criuengine -cp <crac-repo>/build/linux-arm64-slow-openjdk/test-support/jtreg_test_jdk_jdk_crac_newArgs_CheckpointInNewMainTest_java/classes/0/jdk/crac/newArgs/CheckpointInNewMainTest.d:<crac-repo>/build/linux-arm64-slow-openjdk/test-support/jtreg_test_jdk_jdk_crac_newArgs_CheckpointInNewMainTest_java/classes/0/test/lib -XX:CRaCEngineOptions=direct_map=false -XX:CRaCCheckpointTo=cr jdk.test.lib.crac.CracTest __run_test__ CheckpointInNewMainTest
> stdout: [
> ]
> stderr: [
> Exception in thread "main" java.lang.IllegalStateException: Some very useful explanation of the problem
>    ...

This pull request has now been integrated.

Changeset: 1cfc81f3
Author:    Timofei Pushkin <tpushkin at openjdk.org>
URL:       https://git.openjdk.org/crac/commit/1cfc81f3542be5eb94bcfbbfe7bce9614659941a
Stats:     16 lines in 1 file changed: 11 ins; 2 del; 3 mod

8364456: [CRaC] Extend error logging of waitForCheckpointed

Reviewed-by: rvansa

-------------

PR: https://git.openjdk.org/crac/pull/254