[crac] RFR: 8365484: [CRaC] Support IgnoreUnrecognizedVMOptions on restore

[Anton Kozlov]

On Wed, 13 Aug 2025 12:29:47 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:

> Makes `IgnoreUnrecognizedVMOptions` restore-settable.
> 
> `IgnoreUnrecognizedVMOptions` is not forwarded to the restored JVM since that does not make much sense.

src/hotspot/share/runtime/arguments.cpp line 2949:

> 2947:     return false;
> 2948:   }
> 2949:   if (strcmp(flag.name(), "IgnoreUnrecognizedVMOptions") == 0) {

I see the test is consistent with this, but why do we don't record IgnoreUnrecognizedVMOptions?

test/jdk/jdk/crac/VMOptionsTest.java line 139:

> 137:         // Only restore-settable options coming from a settings file => should succeed
> 138:         builder.clearVmOptions();
> 139:         builder.vmOption("-XX:Flags=" + createSettingsFile(OPTIONS_RESTORE));

It seems we replace full path to the engine with the engine name, which is actually a relative path. I'm not sure, why the path was in the first place?

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/263#discussion_r2288022829
PR Review Comment: https://git.openjdk.org/crac/pull/263#discussion_r2288008833