[crac] RFR: 8365484: [CRaC] Support IgnoreUnrecognizedVMOptions on restore
Anton Kozlov
akozlov at openjdk.org
Wed Aug 20 13:06:52 UTC 2025
On Wed, 20 Aug 2025 12:47:51 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:
>> test/jdk/jdk/crac/VMOptionsTest.java line 139:
>>
>>> 137: // Only restore-settable options coming from a settings file => should succeed
>>> 138: builder.clearVmOptions();
>>> 139: builder.vmOption("-XX:Flags=" + createSettingsFile(OPTIONS_RESTORE));
>>
>> It seems we replace full path to the engine with the engine name, which is actually a relative path. I'm not sure, why the path was in the first place?
>
> We need a different value of `CRaCEngine` VM option on checkpoint and on restore to check that on restore it does not change. It does not matter what values are used unless they make JVM use the same engine.
>
> We can check that just the origin of the option has not changed but checking the value too covers more errors.
I see, thanks.
-------------
PR Review Comment: https://git.openjdk.org/crac/pull/263#discussion_r2288103996
More information about the crac-dev
mailing list