[crac] RFR: 8373687: [CRaC] Add metrics through jcmd [v5]

[Radim Vansa]

On Mon, 22 Dec 2025 14:28:11 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:

>> Radim Vansa has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix MacOSX
>
> src/hotspot/share/services/diagnosticCommand.cpp line 1092:
> 
>> 1090:   const char *metrics = _metrics.value();
>> 1091:   if (metrics != nullptr) {
>> 1092:     LocaleGuard lg;
> 
> What is the problem with locales? Why is this needed for metrics but not labels?

The problem I've faced with my (czech) locale is that we use comma `,` for decimal point, rather than `.`. Printing and parsing `double` values was using my locale, then, despite from the info I found JDK should setup the C locale at boottime and use that....

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/281#discussion_r2640999985