[crac] RFR: 8373687: [CRaC] Add metrics through jcmd [v5]
Radim Vansa
rvansa at openjdk.org
Mon Dec 22 20:35:35 UTC 2025
On Mon, 22 Dec 2025 13:51:40 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:
>> Radim Vansa has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix MacOSX
>
> src/hotspot/share/runtime/crac.cpp line 714:
>
>> 712: // silently ignoring this
>> 713: return true;
>> 714: }
>
> I think we should at least print a warning in such case. I.e. expose a method for the JCMD code to check for support and print the warning to the JCMD stream if there's none. Then here we should fail in such case.
>
> Same for `record_image_score`.
I agree that an explicit command like `jcmd` should print a warning if part of the command line is ignored, but I don't want any warnings the be emitted when using the `Score` methods. And for that I'd like to keep the symmetry with the `record_image_score`.
-------------
PR Review Comment: https://git.openjdk.org/crac/pull/281#discussion_r2641161012
More information about the crac-dev
mailing list