[crac] RFR: 8373687: [CRaC] Add metrics through jcmd [v6]
Timofei Pushkin
tpushkin at openjdk.org
Tue Dec 23 07:21:36 UTC 2025
On Mon, 22 Dec 2025 21:20:06 GMT, Radim Vansa <rvansa at openjdk.org> wrote:
>> Enable user adding custom metrics (and labels) through jcmd JDK.checkpoint command, e.g. using
>>
>> jcmd <pid> JDK.checkpoint metrics=foo=123,bar=0.456
>
> Radim Vansa has updated the pull request incrementally with one additional commit since the last revision:
>
> Address review
Marked as reviewed by tpushkin (Committer).
src/hotspot/share/utilities/stringUtils.hpp line 48:
> 46: *strp += len + 1;
> 47: return str;
> 48: }
Why not put the implementation in .cpp?
src/hotspot/share/utilities/stringUtils.hpp line 50:
> 48: }
> 49: #endif // _WINDOWS
> 50:
Redundant newline added
-------------
PR Review: https://git.openjdk.org/crac/pull/281#pullrequestreview-3606903419
PR Review Comment: https://git.openjdk.org/crac/pull/281#discussion_r2642227071
PR Review Comment: https://git.openjdk.org/crac/pull/281#discussion_r2642228931
More information about the crac-dev
mailing list