[crac] RFR: 8349365: [CRaC] Handle javaagent adding jars to boostrap/system classpath

Radim Vansa rvansa at openjdk.org
Thu Feb 6 09:58:37 UTC 2025


On Wed, 5 Feb 2025 15:31:40 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:

>> File descriptors owned by `ClassPathEntry` in `ClassLoader` are ignored during checkpoint.
>
> src/hotspot/os/linux/crac_linux.cpp line 305:
> 
>> 303:   bool ok = true;
>> 304: 
>> 305:   GrowableArray<int> boot_classpath_fds = ClassLoader::get_classpath_entry_fds();
> 
> I believe `GrowableArray` allocates in the resource area by default so a `ResourceMark` should probably be added?

Right, looks like there's no close ResourceMark above in the call stack so this might actually leak?

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/201#discussion_r1944431219


More information about the crac-dev mailing list