[crac] RFR: 8349560: [CRaC] Close EPoll FDs when FD policies close registered sockets [v2]
Timofei Pushkin
tpushkin at openjdk.org
Thu Feb 13 14:10:35 UTC 2025
On Wed, 12 Feb 2025 17:01:15 GMT, Radim Vansa <rvansa at openjdk.org> wrote:
>> FD policies are applied as the last set of JDK resources. When these are meant to close server sockets, it’s rather too late: open EPoll FDs won’t be closed automatically as these have the socket still registered when the automatic close is performed.
>>
>> We can apply FD policies on sockets and close these if requested before EPoll FD handling. The downside is that we would not handle sockets opened during checkpoint, but generally the application should not do that.
>>
>> Besides changing the order of closing this PR also improves the way EPoll FDs are reported: the Selector throws BusySelectorException listing channels registered on that selector, and EPoll FD and Event Epoll FD are claimed through Java code with message referencing the selector (this suppresses native open FD detection that wouldn't provide much info).
>
> Radim Vansa has updated the pull request incrementally with two additional commits since the last revision:
>
> - Use IOUtil.newFd rather than FileDescriptorAccess
> - Change Pollers priority to NORMAL
LGTM
-------------
Marked as reviewed by tpushkin (Author).
PR Review: https://git.openjdk.org/crac/pull/202#pullrequestreview-2615104848
More information about the crac-dev
mailing list