[crac] RFR: 8348869: [CRaC] Restore args are split by whitespaces incorrectly

Radim Vansa rvansa at openjdk.org
Wed Jan 29 12:17:11 UTC 2025


On Tue, 28 Jan 2025 15:05:55 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:

> Fixes the issue by creating a new property `sun.java.crac_command` with spaces escaped. On restore, JVM parses this string de-escaping symbols.
> 
> Replaces abandoned #101.

src/java.base/share/classes/jdk/internal/crac/mirror/Core.java line 243:

> 241:             final char escChar = '\\';
> 242:             final char sepChar = ' ';
> 243:             ArrayList<String> argList = new ArrayList<String>();

Could you please rewrite this using `ArrayList<StringBuilder>`?

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/193#discussion_r1933773677


More information about the crac-dev mailing list