[crac] RFR: 8348927: [CRaC] Handle boot-id not ending with newline

Timofei Pushkin tpushkin at openjdk.org
Thu Jan 30 08:19:59 UTC 2025


On Wed, 29 Jan 2025 07:38:02 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:

> Besides fixing the problem described in the JDK issue:
> - Report errors through `log_error(crac)`, not `perror()`
> - Don't leak a file descriptor on error

`java/util/HashMap/WhiteBoxResizeTest` first [failed on macos-x64](https://github.com/TimPushkin/crac/actions/runs/13026617041/attempts/1#summary-36338758921) then I reran the workflow and it [failed on macos-aarch64](https://github.com/TimPushkin/crac/actions/runs/13026617041/attempts/2#summary-36371440748) (but not on x64).

I've run the test locally on my ARM64 Mac 5 times: 4 successes, 1 failure with the same error. I've run the test without this change more than 10 times and it hasn't failed once.

I don't remember seeing this test failing before so I am a suspicious. But I don't see how the change can be related to the test (the change is for linux, not macos), and the error itself seems unrelated. So I am inclined to believe that the test is to blame. WDYT?

-------------

PR Comment: https://git.openjdk.org/crac/pull/196#issuecomment-2623813596


More information about the crac-dev mailing list