[crac] RFR: 8362837: [CRaC] jdk/crac/MXBean.java can fail on macOS [v4]
Timofei Pushkin
tpushkin at openjdk.org
Mon Jul 21 07:01:18 UTC 2025
On Sun, 20 Jul 2025 20:01:34 GMT, Jan Kratochvil <jkratochvil at openjdk.org> wrote:
>> The CI runs fine but locally (Linux Fedora 42 x86_64) it is failing for me - for any testcase trying to use OutputAnalyzer for the restore-only part. Such testcases failing for me are for example:
>> - test/jdk/jdk/crac/fileDescriptors/CheckpointWithOpenFdsTest.java
>> - test/jdk/jdk/crac/fileDescriptors/LoggingFileOpenTest.java
>> - test/jdk/jdk/crac/SecureRandom/ReseedTest.java
>>
>> It does not implement the part
>>
>>> close to 0
>>
>> as that is the problem being fixed.
>
> Jan Kratochvil has updated the pull request incrementally with two additional commits since the last revision:
>
> - Second TimPushkin's patch
> - 1st patch by TimPushkin
LGTM, although it is my own suggestion.
If the reduced time tolerance will be too low for our CI we can raise it downstream. But I hope it won't be necessary.
-------------
Marked as reviewed by tpushkin (Committer).
PR Review: https://git.openjdk.org/crac/pull/246#pullrequestreview-3036802171
More information about the crac-dev
mailing list