[crac] RFR: 8362837: [CRaC] jdk/crac/MXBean.java can fail on macOS [v4]
Radim Vansa
rvansa at openjdk.org
Mon Jul 21 12:37:00 UTC 2025
On Mon, 21 Jul 2025 09:40:55 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:
>> Jan Kratochvil has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Second TimPushkin's patch
>> - 1st patch by TimPushkin
>
> Maybe I am indeed overcomplicating it and just checking that the values are somewhat meaningful with a large tolerance (or none at all) is enough, as Jan suggests
@TimPushkin It asserts that the value we get is in a reasonable range (it's not entirely bogus value).
>From test code-smell POV, it is a bit weird when one test does something different on Linux and other platforms.
I won't push the ultimate decision what to do with this test, though.
-------------
PR Comment: https://git.openjdk.org/crac/pull/246#issuecomment-3096564207
More information about the crac-dev
mailing list