[crac] RFR: Merge jdk:jdk-25+26
Timofei Pushkin
tpushkin at openjdk.org
Thu Jul 24 19:19:28 UTC 2025
On Thu, 24 Jul 2025 18:56:13 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:
>> Since the merge for [JDK-8352675](https://bugs.openjdk.org/browse/JDK-8352675) is split into a separate PR (https://github.com/openjdk/crac/pull/247), I cherry-picked the current version and merging other changes on top of it. It will likely require rebase on top of the final version later.
>>
>> Attaching output of `--diff-merges=remerge`
>>
>> <details>
>>
>> <summary>Conflicts</summary>
>>
>>
>> commit 5035f463900712ae47b7e1adfeff609bc1d66116 (HEAD -> merge-jdk, dmitry-crac/merge-jdk)
>> Merge: d61227fe01d c59e44a7aa2
>> Author: Dmitry Cherepanov <dcherepanov at azul.com>
>> Date: Tue Jul 22 13:30:47 2025 +0400
>>
>> Merge with jdk-25+26
>>
>> diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
>> remerge CONFLICT (content): Merge conflict in .github/workflows/main.yml
>> index 8cf745c1cff..02c6f3d2668 100644
>> --- a/.github/workflows/main.yml
>> +++ b/.github/workflows/main.yml
>> @@ -310,11 +310,7 @@ jobs:
>> uses: ./.github/workflows/build-windows.yml
>> with:
>> platform: windows-x64
>> -<<<<<<< d61227fe01d (8352675: Support Intel AVX10 converged vector ISA feature detection)
>> msvc-toolset-version: '14.44'
>> -=======
>> - msvc-toolset-version: '14.43'
>> ->>>>>>> c59e44a7aa2 (8357914: TestEmptyBootstrapMethodsAttr.java fails when run with TEST_THREAD_FACTORY=Virtual)
>> msvc-toolset-architecture: 'x86.x64'
>> configure-arguments: ${{ github.event.inputs.configure-arguments }}
>> make-arguments: ${{ github.event.inputs.make-arguments }}
>> @@ -326,11 +322,7 @@ jobs:
>> uses: ./.github/workflows/build-windows.yml
>> with:
>> platform: windows-aarch64
>> -<<<<<<< d61227fe01d (8352675: Support Intel AVX10 converged vector ISA feature detection)
>> msvc-toolset-version: '14.44'
>> -=======
>> - msvc-toolset-version: '14.43'
>> ->>>>>>> c59e44a7aa2 (8357914: TestEmptyBootstrapMethodsAttr.java fails when run with TEST_THREAD_FACTORY=Virtual)
>> msvc-toolset-architecture: 'arm64'
>> make-target: 'hotspot'
>> extra-conf-options: '--openjdk-target=aarch64-unknown-cygwin'
>> @@ -369,17 +361,17 @@ jobs:
>> runs-on: ubuntu-22.04
>> debug-suffix: -debug
>>
>> - test-linux-x64-static:
>> - name: linux-x64-static
>> - needs:
>> - - build-linux-x64
>> - - build-linux-x64-static
>> - uses: ./.github/workflows/test.yml
>> - with:
>> - platform: linux-x64
>> - bootjdk-platform: linux-x64
>> - runs-on: ubuntu-22.04
>> - static-suffix: "-st...
>
> src/hotspot/share/gc/z/zUncommitter.cpp line 444:
>
>> 442: void ZUncommitter::wait_for_finish_force_uncommit() {
>> 443: ZLocker<ZConditionLock> locker(&_force_uncommit_lock);
>> 444: while (_force_uncommit) {
>
> Have not checked but I believe with `-XX:-ZUncommit` we will wait here forever since the uncommitting threads will be doing nothing
Also adding `&& !_stop` might be a good idea
-------------
PR Review Comment: https://git.openjdk.org/crac/pull/248#discussion_r2229341182
More information about the crac-dev
mailing list