[crac] RFR: Fix up CPUFeatures on top of Merge jdk:jdk-25+26 [v2]

[Jan Kratochvil]

On Fri, 25 Jul 2025 12:38:57 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:

>> Jan Kratochvil has updated the pull request incrementally with four additional commits since the last revision:
>> 
>>  - update test/lib-test/jdk/test/whitebox/CPUInfoTest.java
>>  - remove args
>>  - List CPUFeatures in Java
>>  - Fix static_assert
>
> src/hotspot/cpu/x86/vm_version_x86.cpp line 919:
> 
>> 917:       return retval;
>> 918:     }
>> 919:   }
> 
> `str` does not seem to be modified in the loop, won't we be parsing only the first part of it on each iteration?

yes, thanks.

> src/hotspot/cpu/x86/vm_version_x86.cpp line 920:
> 
>> 918:     }
>> 919:   }
>> 920:   vm_exit_during_initialization(err_msg("VM option 'CPUFeatures=%s' must be of the form: 0xnum,0xnum", str));
> 
> This implies `count == 2`, maybe we should add a static assert?

I missed that, thanks.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/250#discussion_r2231570331
PR Review Comment: https://git.openjdk.org/crac/pull/250#discussion_r2231570614