[crac] RFR: Fix up CPUFeatures on top of Merge jdk:jdk-25+26 [v2]
Jan Kratochvil
jkratochvil at openjdk.org
Fri Jul 25 16:54:53 UTC 2025
On Fri, 25 Jul 2025 12:59:12 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:
>> Jan Kratochvil has updated the pull request incrementally with four additional commits since the last revision:
>>
>> - update test/lib-test/jdk/test/whitebox/CPUInfoTest.java
>> - remove args
>> - List CPUFeatures in Java
>> - Fix static_assert
>
> src/hotspot/cpu/x86/vm_version_x86.cpp line 2566:
>
>> 2564: if (ShowCPUFeatures) {
>> 2565: char buf[MAX_CPU_FEATURES * 16];
>> 2566: (*data).print_numbers_and_names(buf, sizeof(buf));
>
> Suggestion:
>
> data->print_numbers_and_names(buf, sizeof(buf));
I have rather made `data` a non-pointer if you agree.
-------------
PR Review Comment: https://git.openjdk.org/crac/pull/250#discussion_r2231597142
More information about the crac-dev
mailing list