[crac] RFR: Fix up CPUFeatures on top of Merge jdk:jdk-25+26 [v7]
Timofei Pushkin
tpushkin at openjdk.org
Sat Jul 26 18:13:08 UTC 2025
On Fri, 25 Jul 2025 18:14:40 GMT, Jan Kratochvil <jkratochvil at openjdk.org> wrote:
>> This pull request contains: https://github.com/openjdk/crac/pull/248
>> I think the CRaC project does not provide the pr/NUMBER branches for dependent patches.
>>
>> This pull request enables the CPUFeatures again.
>
> Jan Kratochvil has updated the pull request incrementally with one additional commit since the last revision:
>
> fix MS-Windows compilation
src/hotspot/cpu/x86/vm_version_x86.cpp line 927:
> 925: s = stpcpy(s, ",0xNUM");
> 926: }
> 927: vm_exit_during_initialization(err_msg("VM option 'CPUFeatures=%s' must be of the form: %s", str, buf + 1));
`str` might have been moved by now so only a part of the actual user input would be printed
src/hotspot/cpu/x86/vm_version_x86.cpp line 2553:
> 2551: print_numbers_and_names(buf, sizeof(buf));
> 2552: tty->print_cr("; missing features of this CPU are %s\n"
> 2553: "If you are sure it will not crash you can override this check by -XX:+UnlockExperimentalVMOptions -XX:+IgnoreCPUFeatures .",
Suggestion:
"If you are sure it will not crash you can override this check by -XX:+UnlockExperimentalVMOptions -XX:+IgnoreCPUFeatures.",
-------------
PR Review Comment: https://git.openjdk.org/crac/pull/250#discussion_r2233124692
PR Review Comment: https://git.openjdk.org/crac/pull/250#discussion_r2233128650
More information about the crac-dev
mailing list