[crac] RFR: Merge jdk:jdk-25+18
Dmitry Cherepanov
dcherepanov at openjdk.org
Mon Jun 23 21:16:58 UTC 2025
On Mon, 23 Jun 2025 09:45:07 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:
> I'm having doubts on JDK-8319055 resolution. I don't see where the connection between `effectively_complete_raw` and `complete` is now? How is it ensured they don't do the same (write the result) twice?
>
> Before this I see that VM thread would call `effectively_complete_raw` before checkpoint which would write the reply and close the socket, then after restore attach listener thread would call `complete` which would **just cleanup the memory**. Now `effectively_complete_raw` will be called as before but after restore `complete` will be called and **try to write something again**?
Thanks for reviewing this.
After JDK-8319055, the attach listener thread first calls to `attachStream::complete` (which writes the result) and then calls to `AttachOperation::complete`.
As a part of the merge, I remove the call to `effectively_complete_raw()` from `PosixAttachOperation::complete` as otherwise it would write the result second time.
-------------
PR Comment: https://git.openjdk.org/crac/pull/238#issuecomment-2997960911
More information about the crac-dev
mailing list