[crac] RFR: 8351701: [CRaC] CRaCEngineOptions=help cannot be used with CRaCRestoreFrom

[Radim Vansa]

On Tue, 11 Mar 2025 18:35:26 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:

> Fixes the issue and adds a regression test for it.

src/hotspot/share/runtime/arguments.cpp line 2264:

> 2262:   postcond(CRaCRestoreFrom != nullptr);
> 2263: 
> 2264:   if (CRaCEngineOptions && strcmp(CRaCEngineOptions, "help") == 0) {

Since you compare the full value, rather than one option... What will

java -XX:CRaCEngineOptions=help -XXCRaCEngineOptions=foo.bar ...

do, and do we have a test for that?

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/211#discussion_r1990191905