[crac] RFR: 8352412: [CRaC] Direct mapping default changed

Timofei Pushkin tpushkin at openjdk.org
Mon Mar 24 12:15:35 UTC 2025


On Mon, 24 Mar 2025 12:07:57 GMT, Radim Vansa <rvansa at openjdk.org> wrote:

>> Changes the default value of `crexec`'s `direct_map` option to true to have the old behavior by default.
>
> Good catch, I should have noticed this in the original review. Can you see any reasonable way to cover this in a test (preferably existing one, e.g. asserting the command line and env vars...)?

@rvansa `CracCriuOptsTest` that will be added in #217 will rely on this and will be checking it as part of its "sanity check". Though that is more of a side-effect of the current implementation of that test, I can make it a separate test here if you prefer.

-------------

PR Comment: https://git.openjdk.org/crac/pull/216#issuecomment-2747923055


More information about the crac-dev mailing list