[crac] RFR: 8352413: [CRaC] crexec fails to pass some options when CRAC_CRIU_OPTS is already used [v2]

[Timofei Pushkin]

On Wed, 19 Mar 2025 13:22:53 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:

>> This contains the change from #216 so that should be merged first.
>> 
>> The fix itself is small but coming up with a way to test it was not trivial:
>> 1. I've split `jdk/crac/CracEngineOptionsTest.java` onto `jdk/crac/engineOptions/ParsingTest.java` and `jdk/crac/engineOptions/HelpTest.java` because it was getting too large (nothing added/removed, just split).
>> 2. Added `jdk/crac/engineOptions/CracCriuOptsTest.java` to regression-test the main fix of this PR (this test depends on #216).
>> 3. Removed a part that tested that `args` are actually applied by `crexec` from `jdk/crac/VMOptionsTest.java` because (2) is now effectively tests this (`VMOptionsTest` wasn't a proper place for this to begin with, it just was convenient).
>
> Timofei Pushkin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Take variable out of loop

I think we shouldn't, I see them as two unrelated issues. The only relation between them is the test for this that relies on #216, but the issues and the fixes themselves are not related.

-------------

PR Comment: https://git.openjdk.org/crac/pull/217#issuecomment-2747967664