[crac] RFR: 8352413: [CRaC] crexec fails to pass some options when CRAC_CRIU_OPTS is already used [v4]

[Radim Vansa]

On Tue, 25 Mar 2025 11:39:04 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:

>> ~~This contains the change from #216 so that should be merged first.~~ UPD: rebased.
>> 
>> The fix itself is small but coming up with a way to test it was not trivial:
>> 1. I've split `jdk/crac/CracEngineOptionsTest.java` onto `jdk/crac/engineOptions/ParsingTest.java` and `jdk/crac/engineOptions/HelpTest.java` because it was getting too large (nothing added/removed, just split).
>> 2. Added `jdk/crac/engineOptions/CracCriuOptsTest.java` to regression-test the main fix of this PR (this test depends on #216).
>> 3. Removed a part that tested that `args` are actually applied by `crexec` from `jdk/crac/VMOptionsTest.java` because (2) is now effectively tests this (`VMOptionsTest` wasn't a proper place for this to begin with, it just was convenient).
>
> Timofei Pushkin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Fix comment in CracCriuOptsTest.java
>  - Take variable out of loop
>  - Fix CRAC_CRIU_OPTS appending

Marked as reviewed by rvansa (Committer).

-------------

PR Review: https://git.openjdk.org/crac/pull/217#pullrequestreview-2713619253