[crac] RFR: 8355974: [CRaC] Move CPUFeatures verification to the parent process of JVM [v8]

[Jan Kratochvil]

On Wed, 30 Apr 2025 18:04:23 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:

>> Jan Kratochvil has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Refactor cpufeatures_check/cpufeatures_load etc.
>
> src/hotspot/share/runtime/crac.cpp line 532:
> 
>> 530:         }
>> 531:         if (!VM_Version::cpu_features_binary_check(present ? &data : nullptr)) {
>> 532:           log_error(crac)("Image %s has incompatible CPU features in its user data %s", CRaCRestoreFrom, engine.cpufeatures_userdata_name);
> 
> I think the user doesn't really need to know the name of the user data in this case, just that the image is incompatible with their CPU. Omitting this would also allow making `cpufeatures_userdata_name` a .cpp static as it was before.

I disagree here. When it is incompatible I want to look at the images with `readelf -n` and to know what to look for. Currently `readelf -n` does not support Warp notes but that should be fixed anyway.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/227#discussion_r2081927984