[crac] RFR: 8355974: [CRaC] Move CPUFeatures verification to the parent process of JVM [v10]
Jan Kratochvil
jkratochvil at openjdk.org
Mon May 12 13:26:19 UTC 2025
On Mon, 12 May 2025 12:30:14 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:
>> src/hotspot/share/runtime/crac_engine.cpp line 444:
>>
>>> 442: // s3->set_image_bitmask did handle it already, load_user_data() is too expensive for S3.
>>> 443: return true;
>>> 444: }
>>
>> There is no special handling for `s3://` paths in this project
>
> @jankratochvil Looks like you missed this comment
I did not, I am addressing that by:
- https://github.com/openjdk/crac/pull/227/commits/719e7568262f87d7367c6656827ece796e35cadb
- https://github.com/openjdk/crac/pull/227/commits/5ce33434f66913f83b53941b4f9aff8d012f6372
But I need to test it against S3 to finish it and so far I have not managed to setup an S3 test.
-------------
PR Review Comment: https://git.openjdk.org/crac/pull/227#discussion_r2084668228
More information about the crac-dev
mailing list