[crac] RFR: 8355974: [CRaC] Move CPUFeatures verification to the parent process of JVM [v11]
Jan Kratochvil
jkratochvil at openjdk.org
Fri May 16 12:30:03 UTC 2025
On Tue, 13 May 2025 19:12:01 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:
>> src/java.base/share/native/libcrexec/crexec.cpp line 559:
>>
>>> 557: }
>>> 558: FILE *f = fopen(fname, "w");
>>> 559: if (f == NULL) {
>>
>> A nitpick, would also be great to replace in the other places in the file
>> Suggestion:
>>
>> if (f == nullptr) {
>
> Would also be great to use `static_cast` and friends instead of C-style casts but since it can be cumbersome to replace sometimes I don't insist
Done the `nullptr`. Personally I do not use C casts in my code at all but by some grepping it looks to me hotspot is mostly using the C costs so I just went with the flow. I do not see casts mentioned in the [style guide](https://github.com/openjdk/jdk/blob/master/doc/hotspot-style.md).
-------------
PR Review Comment: https://git.openjdk.org/crac/pull/227#discussion_r2092944469
More information about the crac-dev
mailing list