[crac] RFR: 8355974: [CRaC] Move CPUFeatures verification to the parent process of JVM
Timofei Pushkin
tpushkin at openjdk.org
Mon May 19 14:19:11 UTC 2025
On Wed, 30 Apr 2025 07:40:02 GMT, Radim Vansa <rvansa at openjdk.org> wrote:
>> That one failure: `Pre-submit tests - linux-x64 / test - Build / test` = `jdk/crac/fileDescriptors/LoggingVMlogOpenTestNegative.java` will IMO disappear after the change gets accepted. The testcase has been changed so that if you run it from the freshly built JVM it works. But Github IIUC runs the parent JVM pre-built, not from the fresh build: `/home/runner/work/crac/crac/bundles/jdk/jdk-25/bin/java`. Or where is this `bundle` JVM from?
>>
>> --- this was a wrong idea - the reality is that the failure was due to release vs. debug build as `LogFile` then behaves differently.
>
> @jankratochvil ~The test is failing for me locally, too~ - does it pass on your machine? I had the test fail for something unrelated.
>
> Could you create JDK issue and refer to that in the title?
@rvansa From my point of view this can be merged (I don't have the rights yet) if the tests pass
-------------
PR Comment: https://git.openjdk.org/crac/pull/227#issuecomment-2891205729
More information about the crac-dev
mailing list