[crac] RFR: Merge jdk:jdk-25+10
Radim Vansa
rvansa at openjdk.org
Tue May 27 06:36:12 UTC 2025
On Mon, 26 May 2025 22:46:46 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:
> This PR includes merges for tags between `jdk-25+5` and `jdk-25+10`, attaching output of `--diff-merges=remerge` for each merge
>
> <details>
>
> <summary>jdk-25+5</summary>
>
>
> commit 5ae68607f0b679587a60a1aab8b2aadb4105bbb7
> Merge: ed3997056b6 2e00816ac30
> Author: Dmitry Cherepanov <dcherepanov at azul.com>
> Date: Mon May 19 22:35:02 2025 +0400
>
> Merge with jdk-25+5
>
>
> </details>
>
> <details>
>
> <summary>jdk-25+6</summary>
>
>
> commit cc975a31216702e48256ad35e96957c978190027
> Merge: 5ae68607f0b 9c430c92257
> Author: Dmitry Cherepanov <dcherepanov at azul.com>
> Date: Mon May 26 20:44:57 2025 +0400
>
> Merge with jdk-25+6
>
> diff --git a/src/hotspot/share/compiler/compileLog.cpp b/src/hotspot/share/compiler/compileLog.cpp
> index 4c8165fc7bd..f183d628d45 100644
> --- a/src/hotspot/share/compiler/compileLog.cpp
> +++ b/src/hotspot/share/compiler/compileLog.cpp
> @@ -340,7 +340,7 @@ void CompileLog::finish_log_on_checkpoint(outputStream* file) {
> // print/print_cr may need to allocate large stack buffer to format
> // strings, here we use snprintf() and print_raw() instead.
> file->print_raw("<compilation_log thread='");
> - jio_snprintf(buf, buflen, UINTX_FORMAT, log->thread_id());
> + jio_snprintf(buf, buflen, "%zu", log->thread_id());
> file->print_raw(buf);
> file->print_raw_cr("'>");
>
> diff --git a/src/hotspot/share/gc/parallel/psParallelCompact.cpp b/src/hotspot/share/gc/parallel/psParallelCompact.cpp
> remerge CONFLICT (content): Merge conflict in src/hotspot/share/gc/parallel/psParallelCompact.cpp
> index 00bb365dffd..438b6b90740 100644
> --- a/src/hotspot/share/gc/parallel/psParallelCompact.cpp
> +++ b/src/hotspot/share/gc/parallel/psParallelCompact.cpp
> @@ -1,10 +1,6 @@
> /*
> -<<<<<<< 5ae68607f0b (Merge with jdk-25+5)
> - * Copyright (c) 2005, 2024, Oracle and/or its affiliates. All rights reserved.
> - * Copyright (c) 2019, 2021, Azul Systems, Inc. All rights reserved.
> -=======
> * Copyright (c) 2005, 2025, Oracle and/or its affiliates. All rights reserved.
> ->>>>>>> 9c430c92257 (8336920: ArithmeticException in javax.sound.sampled.AudioInputStream)
> + * Copyright (c) 2019, 2021, Azul Systems, Inc. All rights reserved.
> * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
> *
> * This code is free software; you can redistribute it and/or modify it
> diff --git a/src/hotspot/share/gc/serial/defNewGeneration.cpp b/src/hotspot/share/gc/serial/defNewGeneration.cpp
> remerge CONFLICT (content): Merge conflict in src/hotspot/share/gc/serial/defNewGeneration.cpp...
The remerge diff looks correct, thanks!
I hope that the `SIZE_FORMAT`/`UINTX` -> `%zu` won't cause differences with CRaC applied into older versions. TBH in my code I've always (I think) used `%zu`, and it seems that C++14 (hence C99) is available since 16, so we shouldn't have an issue with that.
Could you check whether there are any uses of these formatters and SecurityManager (which is a pattern that is removed by these changes) throughout CRaC codebase?
-------------
PR Review: https://git.openjdk.org/crac/pull/231#pullrequestreview-2869771177
More information about the crac-dev
mailing list