[crac] RFR: 8354679: [CRaC] jdk.crac.management makes JdkManagementCheckSince fail

Timofei Pushkin tpushkin at openjdk.org
Tue May 27 12:37:42 UTC 2025


On Wed, 16 Apr 2025 13:13:20 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:

> Fixes the failing test, by using `@since CRaC` in CRaC docs and `--ignoreSince` in since-checker tests which check them.
> 
> A since-checker test for `jdk.crac` module is also added but it is disabled until [JDK-8354921](https://bugs.openjdk.org/browse/JDK-8354921) is fixed.
> 
> Also adds the since-checking tests to CI.

[JDK-8345212](https://bugs.openjdk.org/browse/JDK-8345212) works as expected. We will be able to just put `@since CRaC` to our `package-info`s and `module-info`s and add `--ignoreSince CRaC` to `SinceChecker` tests that touch CRaC sources.

I think this approach is better because we won't have to update the symbols on every release (possibly multiple times) and it seems to be the accepted way for long-running non-mainline projects (this is the reasoning in JDK-8345212).

JDK-8345212 will come with jdk-25+10, we are now at jdk-25+4. I'll leave this PR as a draft until then. After that I'll change it to satisfy JDK-8345212.

We should now use `@since CRaC` in CRaC docs and add `--ignoreSince CRaC` to since-checker tests of modules containing documented CRaC code.

I also added a disabled since-checker test for `jdk.crac` module. It can be enabled after [JDK-8354921](https://bugs.openjdk.org/browse/JDK-8354921) is fixed.

Since-checker will also be run in our CI.

-------------

PR Comment: https://git.openjdk.org/crac/pull/225#issuecomment-2903815445
PR Comment: https://git.openjdk.org/crac/pull/225#issuecomment-2912335357


More information about the crac-dev mailing list