[crac] RFR: 8367975: [CRaC] Pattern in CRaCCheckpointTo [v2]

[Timofei Pushkin]

On Tue, 30 Sep 2025 08:58:33 GMT, Radim Vansa <rvansa at openjdk.org> wrote:

>> Add support for pattern in `CRaCCheckpointTo` VM option.
>
> Radim Vansa has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address review comments

src/hotspot/share/runtime/crac.cpp line 155:

> 153:     } else if ((size_t) ret > buflen) { \
> 154:       log_error(crac)("Error interpolating CRaCCheckpointTo=%s", CRaCCheckpointTo); \
> 155:       return false; \

Shouldn't the error messages be swapped? For snprintf, if `ret > buflen` then the buffer was too small, if `ret < 0` then it is some encoding error. Also I think it should be `ret >= buflen` since `ret` does not count the nul terminator.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/264#discussion_r2398065792