[crac] RFR: 8367975: [CRaC] Pattern in CRaCCheckpointTo [v6]
Timofei Pushkin
tpushkin at openjdk.org
Wed Oct 8 07:51:55 UTC 2025
On Tue, 7 Oct 2025 12:07:08 GMT, Radim Vansa <rvansa at openjdk.org> wrote:
>> Add support for pattern in `CRaCCheckpointTo` VM option.
>
> Radim Vansa has updated the pull request incrementally with two additional commits since the last revision:
>
> - Review comments
> - Fix build & test
LGTM
src/hotspot/share/runtime/crac.cpp line 294:
> 292: #ifndef PATH_MAX
> 293: # define PATH_MAX 1024
> 294: #endif
Not critical, but we could also try `MAX_PATH` defined in Windows before falling back to a hard-coded value
-------------
Marked as reviewed by tpushkin (Committer).
PR Review: https://git.openjdk.org/crac/pull/264#pullrequestreview-3313385914
PR Review Comment: https://git.openjdk.org/crac/pull/264#discussion_r2412866979
More information about the crac-dev
mailing list