[crac] RFR: 8368929: [CRaC] Move CPUFeatures check to C/R engine [v11]

[Radim Vansa]

On Wed, 8 Oct 2025 09:09:17 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:

>> Radim Vansa has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Apply suggestions from code review
>>   
>>   Co-authored-by: Timofei Pushkin <pushkin.td at gmail.com>
>
> src/java.base/share/native/libcrexec/hashtable.hpp line 136:
> 
>> 134: 
>> 135: template<class T> template<typename TT>
>> 136: bool Hashtable<T>::put(const char* key, TT&& value) {
> 
> A total nitpick, but now we have `const char *key` in the declaration and `const char* key` in the definition. When I was rewriting crexec into C++ I used the `type *x`, `type * const x` style everywhere. But since there is no linter for this in CI it seems that there is no sense in trying to keep it in a single style, it will diverge with time anyway...

To me, it makes little sense to use `T&& x` and `T *x`, and we should be consistent at least on the file level. And yes, without linting I'll always forget it somewhere...

While I personally prefer `T *x`, from some recent mainline JDK PRs I think that the project prefers `T* x`, so let's use that.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/266#discussion_r2418762365