[crac] RFR: 8369566: CRaC: Record metrics during checkpoint [v4]

[Timofei Pushkin]

On Wed, 22 Oct 2025 11:19:21 GMT, Radim Vansa <rvansa at openjdk.org> wrote:

>> CRaC Engine can support storing additional metadata about the image. This can help the infrastructure to further refine the set of feasible images (constrained by CPU architecture and features) and select the image that is expected to perform best.
>
> Radim Vansa has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update after review

src/java.base/share/native/libcrexec/crexec.hpp line 45:

> 43:   inline deferred(F f): _f(f) {}
> 44:   inline ~deferred() { _f(); }
> 45: };

Nitpicks: class names are normally capitalized and the constructed should probably be explicit

src/java.base/share/native/libcrexec/hashtable.hpp line 128:

> 126:   const unsigned int hash = string_hash(key) % _capacity;
> 127:   for (size_t i = hash; i < _capacity; i++) {
> 128:     if (strcmp(key, _keys[i]) == 0) {

Since the number of keys can now be less than capacity, i.e. some stored keys may be uninitialized, we should check `_keys[i] != nullptr`

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/269#discussion_r2454237029
PR Review Comment: https://git.openjdk.org/crac/pull/269#discussion_r2454333630