[crac] RFR: 8369566: CRaC: Record metrics during checkpoint [v7]

Radim Vansa rvansa at openjdk.org
Thu Oct 23 13:13:30 UTC 2025


On Thu, 23 Oct 2025 12:49:11 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:

>> Radim Vansa has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add README, truncate metric name, expose jdk.crac.internalResources
>
> src/java.base/share/classes/jdk/internal/crac/Score.java line 67:
> 
>> 65:         int resources = 0;
>> 66:         for (var p : Core.Priority.values()) {
>> 67:             if (p.getContext() instanceof OrderedContext<?> octx) {
> 
> I would prefer a cast just to ensure we don't miss a resource, but for now this should be equivalent

`Core.Priority.SCORE.getContext()` is not an `OrderedContext`.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/269#discussion_r2455084101


More information about the crac-dev mailing list