[crac] RFR: 8367975: [CRaC] Pattern in CRaCCheckpointTo

[Radim Vansa]

On Mon, 22 Sep 2025 14:59:55 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:

>> Add support for pattern in `CRaCCheckpointTo` VM option.
>
> src/hotspot/share/runtime/crac.cpp line 188:
> 
>> 186:           check_no_width();
>> 187: #ifndef ARCHPROPNAME // defined by build scripts
>> 188: # define ARCHPROPNAME "unknown"
> 
> Why not assert it is defined?
> Suggestion:
> 
> #error ARCHPROPNAME macro must be defined

I had the `define` here mostly to avoid IDE errors, but OK...

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/264#discussion_r2372139319