[crac] RFR: 8367975: [CRaC] Pattern in CRaCCheckpointTo
Timofei Pushkin
tpushkin at openjdk.org
Tue Sep 23 12:34:15 UTC 2025
On Tue, 23 Sep 2025 12:24:43 GMT, Radim Vansa <rvansa at openjdk.org> wrote:
>> src/hotspot/share/runtime/crac.cpp line 198:
>>
>>> 196: buf += ret;
>>> 197: buflen -= ret;
>>> 198: } // otherwise just empty string
>>
>> I think we should print a warning otherwise
>
> I don't think so; `cpu_features_binary` will return false on `aarch64`, and I don't think the user has to use different patterns to checkpoint on different architectures.
>From the other hand, it can be confusing to get absolutely nothing in the place of this pattern. But if we explicitly document that this is possible, I am OK with leaving it as is.
-------------
PR Review Comment: https://git.openjdk.org/crac/pull/264#discussion_r2372166780
More information about the crac-dev
mailing list