[crac] RFR: 8367975: [CRaC] Pattern in CRaCCheckpointTo [v4]
Radim Vansa
rvansa at openjdk.org
Tue Sep 30 09:35:24 UTC 2025
On Tue, 23 Sep 2025 10:05:23 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:
>> Radim Vansa has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Notice about empty %f
>
> The patterns should be documented in `java.md` and maybe mentioned in `globals.hpp`.
>
> Also since the patterns are handled in shared code it would make sense to have OS pattern too.
@TimPushkin Thank you for the review, I've addressed all your comments, I think.
I've considered adding `%o` for OS name matching `os.name` property, but turns out this is non-trivial outside POSIX systems where `struct utsname.sysname` (from `uname`) is used: on Mac's this is hardcoded, on Windows there's a complex switch and this is not exposed in VM code through some `os::name()` adapter. So I won't go the extra miles to get the value; I don't think that in practice this will be used on non-Linux systems anyway.
-------------
PR Comment: https://git.openjdk.org/crac/pull/264#issuecomment-3350957686
More information about the crac-dev
mailing list