[crac] RFR: 8376959: [CRaC] Turn simengine into shared library [v2]
Radim Vansa
rvansa at openjdk.org
Tue Feb 3 14:39:29 UTC 2026
On Tue, 3 Feb 2026 11:42:21 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:
>> Radim Vansa has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Implement static build & other platforms
>
> src/hotspot/share/runtime/crac_engine.cpp line 116:
>
>> 114: assert(sizeof(SIMENGINE) <= resolved_engine_size, "must be");
>> 115: memcpy(resolved_engine, SIMENGINE, sizeof(SIMENGINE));
>> 116: log_warning(crac)("-XX:CRaCEngine=pause/pauseengine is deprecated; use -XX:CRaCEngine=simengine -XX:CRaCEngineOptions=pause=true");
>
> Let's define an obsoletion/expiration version for this. I suggest 28 for both obsoletion and expiration: this way for LTS releases it will be deprecated in April 2026 and obsoleted+expired in April 2027.
>
> Suggestion:
>
> assert(JDK_Version::current().compare(JDK_Version::jdk(28)) < 0, "pauseengine handling must be removed as obsolete");
> if (is_pauseengine()) {
> assert(sizeof(SIMENGINE) <= resolved_engine_size, "must be");
> memcpy(resolved_engine, SIMENGINE, sizeof(SIMENGINE));
> log_warning(crac)("Option '-XX:CRaCEngine=pauseengine' was deprecated in version 27 and will be removed in version 28. Use options '-XX:CRaCEngine=simengine -XX:CRaCEngineOptions=pause=true' instead.");
April 2026 is 27, a STS version, and 28 is STS as well (not that it would matter so much in CRaC - we haven't been updating the older branches anyway). I am OK to expire this in 28, though.
-------------
PR Review Comment: https://git.openjdk.org/crac/pull/289#discussion_r2759409193
More information about the crac-dev
mailing list