[crac] RFR: 8372933: [CRaC] Restore failed due to incompatible or missing CPU features, try using -XX:CPUFeatures=0xfoo, 0xbar on checkpoint [v10]
Radim Vansa
rvansa at openjdk.org
Wed Feb 4 11:52:27 UTC 2026
On Wed, 4 Feb 2026 08:27:26 GMT, Jan Kratochvil <jkratochvil at openjdk.org> wrote:
>> Since [JDK-8368929](https://bugs.openjdk.org/browse/JDK-8368929) the message:
>>
>>
>> Restore failed due to incompatible or missing CPU features, try using -XX:CPUFeatures=0xe14e1805fdfbf7,0xfcc on checkpoint.
>>
>>
>> is wrong as it does not do logical and of both CPUFeatures masks.
>>
>> Yes, I should have caught it during [JDK-8368929](https://bugs.openjdk.org/browse/JDK-8368929) review.
>>
>> @rvansa will probably want to change the API but this is a PoC how it should work.
>
> Jan Kratochvil has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 16 additional commits since the last revision:
>
> - Merge branch 'crac' into crac-conjunction
> - Revert the check
> - Fix the sizeof check
> - get_failed_bitmap: return size_t
> - Use current_features everywhere
> - Fix "try using -XX:CPUFeatures" for the 'exact' case.
> - Check for failed malloc
> - Fix non-x86 builds
> - get_failed_bitmap to return stored data
> - Merge branch 'crac' into crac-conjunction
> - ... and 6 more: https://git.openjdk.org/crac/compare/dbaf6cfe...d27c0e7a
Marked as reviewed by rvansa (Committer).
-------------
PR Review: https://git.openjdk.org/crac/pull/278#pullrequestreview-3750598483
More information about the crac-dev
mailing list