[crac] RFR: 8377177: [CRaC] Clarify engine use in the testsuite [v2]

Timofei Pushkin tpushkin at openjdk.org
Thu Feb 5 12:27:43 UTC 2026


On Thu, 5 Feb 2026 09:56:43 GMT, Radim Vansa <rvansa at openjdk.org> wrote:

>> If possible, test should use simengine.
>> If the test is specific to engine behaviour, it should use CracBuilder.engine(...) explicitly.
>> If the test can cover more generic behaviour of real engines, either use the default or accept the engine as test arg.
>
> Radim Vansa has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Assert number of CracTest arguments

Could you please document the policy as the doc of `engine(...)` method? Probably worth noting that the default is guaranteed to be some "real" engine (but not necessarily CRIU).

-------------

PR Review: https://git.openjdk.org/crac/pull/291#pullrequestreview-3756799722


More information about the crac-dev mailing list