[crac] RFR: 8376959: [CRaC] Turn simengine into shared library [v5]
Radim Vansa
rvansa at openjdk.org
Thu Feb 12 10:58:49 UTC 2026
On Mon, 9 Feb 2026 08:04:33 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:
>>> > The point of this PR is not to change crexec, that's why I haven't really touched the README. I think that it can be completely removed in the follow-up
>>>
>>> We added the doc because otherwise the format of saved scores is not documented anywhere. I am OK with addressing this in the PR that will remove crexec but the doc should be retained in some place common for engines that use crcommon.
>>
>> I've checked the README again, and I think that for the reason's above it should be retained as-is in `libcrexec`/`libcriuengine`, rather than in libcrcommon. I can add a README into `libsimengine` saying that the format should be the same as `libcrexec`, but the existence of `libcrcommon` is an implementation detail, rather than something user-facing.
>
>> I can add a README into libsimengine saying that the format should be the same as libcrexec
>
> Sounds good to me
@TimPushkin The build is passing, please re-check.
-------------
PR Comment: https://git.openjdk.org/crac/pull/289#issuecomment-3890167392
More information about the crac-dev
mailing list