[crac] RFR: 8378446: [CRaC] Replace libcrexec with libcriuengine [v2]
Radim Vansa
rvansa at openjdk.org
Wed Feb 25 12:47:45 UTC 2026
On Tue, 24 Feb 2026 14:03:57 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:
>> Radim Vansa has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
>>
>> - Merge remote-tracking branch 'origin/crac' into crexec_to_criuengine
>> - Fix Windows build
>> - 8378446: [CRaC] Replace libcrexec with libcriuengine
>
> src/hotspot/share/runtime/crac_engine.cpp line 313:
>
>> 311: if (is_vm_statically_linked()) {
>> 312: log_warning(crac)("Cannot load CRaC engine API entrypoint '%s' from %s", resolved_engine_func, path);
>> 313: // Maybe the deprecated short name was used, in that case find_engine did not amend the 'engine'
>
> Maybe I miss a case where this may happen but shouldn't it be handled here: https://github.com/rvansa/crac/blob/807167d37ca7cf6e2b079d18a45a768e24478083/src/hotspot/share/runtime/crac_engine.cpp#L147?
For static VM we take a shortcut as we cannot check the filesystem path: https://github.com/rvansa/crac/blob/807167d37ca7cf6e2b079d18a45a768e24478083/src/hotspot/share/runtime/crac_engine.cpp#L135
Yes, it is redundant, so I hope to remove this in 28 when we don't allow short engine names anymore.
-------------
PR Review Comment: https://git.openjdk.org/crac/pull/297#discussion_r2852835375
More information about the crac-dev
mailing list