[crac] RFR: 8374614: [CRaC] Remove defunct fdinfo marking

Timofei Pushkin tpushkin at openjdk.org
Fri Jan 9 07:17:00 UTC 2026


On Tue, 6 Jan 2026 14:21:00 GMT, Radim Vansa <rvansa at openjdk.org> wrote:

> When initializing fdinfos, there might be a racy native thread closing FD between enumerating FDs and `readlink /proc/self/fd/XXX`, causing an error and assertion to fail.
> 
> Further looking into the code it seems that the fdinfo::mark is not read since https://github.com/openjdk/crac/commit/4b0dc2dc9722945579c9772b335a44fa79f1729f and therefore the whole check is defunct, and can be removed.

AFAIU this solves or duplicates https://bugs.openjdk.org/browse/JDK-8374791 — could you link it properly to this bug?

src/hotspot/os/linux/crac_linux.cpp line 57:

> 55:     state_t state;
> 56: 
> 57:     int flags;

While we are at it, looks like this is also unused

-------------

PR Review: https://git.openjdk.org/crac/pull/284#pullrequestreview-3642657652
PR Review Comment: https://git.openjdk.org/crac/pull/284#discussion_r2675087166


More information about the crac-dev mailing list