[crac] RFR: 8374614: [CRaC] Remove defunct fdinfo marking [v2]

Timofei Pushkin tpushkin at openjdk.org
Fri Jan 9 13:00:38 UTC 2026


On Fri, 9 Jan 2026 11:30:56 GMT, Radim Vansa <rvansa at openjdk.org> wrote:

>> When initializing fdinfos, there might be a racy native thread closing FD between enumerating FDs and `readlink /proc/self/fd/XXX`, causing an error and assertion to fail.
>> 
>> Further looking into the code it seems that the fdinfo::mark is not read since https://github.com/openjdk/crac/commit/4b0dc2dc9722945579c9772b335a44fa79f1729f and therefore the whole check is defunct, and can be removed.
>
> Radim Vansa has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove unused flags field

Marked as reviewed by tpushkin (Committer).

-------------

PR Review: https://git.openjdk.org/crac/pull/284#pullrequestreview-3643831754


More information about the crac-dev mailing list