[crac] RFR: 8375044: [CRaC] Structured engine options info [v4]

Radim Vansa rvansa at openjdk.org
Tue Jan 20 15:52:05 UTC 2026


On Mon, 19 Jan 2026 09:58:58 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:

>> Radim Vansa has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix windows build
>
> src/hotspot/share/runtime/crac_engine.cpp line 424:
> 
>> 422: 
>> 423: const crlib_conf_option_t *CracEngine::configuration_options() const {
>> 424:   static crlib_conf_option_t *all_options = nullptr;
> 
> I doubt that the documentation code will be performance-critical so I'd prefer to remove this caching to leave the possibility of using `CracEngine` for different engines within a process. I don't have a practical use case yet, just seems cleaner.

This is not only about caching, but also about managing the lifecycle, any symmetry with `configuration_doc` (which is not released by the caller).  But I can keep the cache in `CRaCEngine`.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/286#discussion_r2708958151


More information about the crac-dev mailing list