[crac] RFR: 8375044: [CRaC] Structured engine options info [v4]
Radim Vansa
rvansa at openjdk.org
Tue Jan 20 16:24:25 UTC 2026
On Tue, 20 Jan 2026 16:20:01 GMT, Radim Vansa <rvansa at openjdk.org> wrote:
>> src/hotspot/share/include/crlib/crlib_description.h line 50:
>>
>>> 48: const char *value_type;
>>> 49: const char *default_value;
>>> 50: const char *description;
>>
>> I'd prefer to have nullability specified for the strings. I think all but `default_value` must be non-nullable. `default_value` probably should be nullable with null representing options without which the engine will always fail C/R (e.g. image and engine locations in case of crexec).
>
> I don't think we need the special `null` case for must-be-set option; it's better to document that there's no default value.
(I've made all of those non-nullable)
-------------
PR Review Comment: https://git.openjdk.org/crac/pull/286#discussion_r2709093298
More information about the crac-dev
mailing list