From philip.race at oracle.com Fri Jun 2 18:17:12 2017 From: philip.race at oracle.com (Phil Race) Date: Fri, 2 Jun 2017 11:17:12 -0700 Subject: CSR issue type now live in JDK project for JDK 10 requests In-Reply-To: References: <5924CE17.1070208@oracle.com> <544e83f6-4829-a5e8-fba4-90cf7680df37@oracle.com> <6bae92c5-8c76-8020-115d-dba971ef9761@oracle.com> <7476a064-79f1-3f4b-2aef-8eaffb9348d3@oracle.com> <62d77361-1f25-8afd-734f-db3e95220e9d@oracle.com>

Message-ID: <1e54e421-5a69-0ec5-9883-52037f9bd08e@oracle.com> FWIW I added faqs on the wiki saying how (not) to create a csr and how to get your text formatted. https://wiki.openjdk.java.net/display/csr/CSR+FAQs -phil. On 05/31/2017 04:13 PM, Phil Race wrote: > I think when Joe gets back from vacation the FAQ etc needs to be a priority. > > -Phil. > >> On May 31, 2017, at 2:40 PM, Martin Buchholz wrote: >> >> >> >>> On Wed, May 31, 2017 at 2:25 PM, Phil Race wrote: >>> I think you are supposed to be able to use markdown syntax. >>> Should be the same as what is supported in JEPs. >> Now you're making me feel guilty for never having filed a JEP ! >> >> OK, much better now after having spent some quality time with a markdown cheat sheet. From philip.race at oracle.com Wed Jun 7 20:58:58 2017 From: philip.race at oracle.com (Philip Race) Date: Wed, 07 Jun 2017 13:58:58 -0700 Subject: Fwd: Re: [OpenJDK 2D-Dev] [10] RFR 8078192: Path2D storage trimming In-Reply-To: <59386886.8050309@oracle.com> References: <59386886.8050309@oracle.com> Message-ID: <59386912.1020604@oracle.com> Tony & Joe, Any idea why I can't set to fix version 10, or assign to Laurent ? -phil. -------- Original Message -------- Subject: Re: [OpenJDK 2D-Dev] [10] RFR 8078192: Path2D storage trimming Date: Wed, 07 Jun 2017 13:56:38 -0700 From: Philip Race Organization: Oracle Corporation To: Laurent Bourg?s CC: Jim Graham , Iris Clark , "2d-dev at openjdk.java.net" <2d-dev at openjdk.java.net> Oh this one is interesting. It already has a CSR :-) That's because we had created a CCC for it back in JDK 9 and then withdrew it. All existing CSRs were ported over but as "confidential" since honestly no one had time to look at all N thousand of them and vet them ... we vetted and opened enough to give people a flavour. So I think that "create a csr" doesn't appear if there already is one since you can't see it. I opened it so you can now see it. https://bugs.openjdk.java.net/browse/CCC-8078192 I re-opened it but don't seem to be able to target it to 10 or assign it to you. I'll need to ask. -phil On 6/7/17, 1:35 PM, Laurent Bourg?s wrote: > Phil, > > Could you initiate the CSR request in JBS ? > I do not see how to create it from the current bug: I looked at the > More menu but I do not have any Create CSR action. > > Cheers, > Laurent > > Le 17 mai 2017 22:05, "Phil Race" > a ?crit : > > Early next week is the hope. > > -phil > > On 05/16/2017 02:20 PM, Laurent Bourg?s wrote: >> Phil, >> >> Did you get any answer from the CSR process on this bug ? >> >> Laurent >> >> >> 2017-04-21 0:17 GMT+02:00 Philip Race > >: >> >> OK. Although we still need to wait for the CSR process. >> >> -phil. >> >> >> On 4/20/17, 3:05 PM, Laurent Bourg?s wrote: >>> Sorry (bad shortcut); >>> >>> Here is the fixed webrev: >>> http://cr.openjdk.java.net/~lbourges/path2D/Path2D-8078192.3/ >>> >>> Laurent >>> >>> 2017-04-21 0:04 GMT+02:00 Laurent Bourg?s >>> >: >>> >>> Sorry for the typo, I added also a newline before @since: >>> >>> >>> 2017-04-20 23:04 GMT+02:00 Philip Race >>> >: >>> >>> You have a capital letter here and I think it must >>> be lower case .. >>> >>> >>> 2499 * @Since 10 >>> >>> -phil. >>> >>> >>> On 4/20/17, 1:58 PM, Laurent Bourg?s wrote: >>>> Hi Phil & Jim, >>>> >>>> Here is the updated webrev: >>>> http://cr.openjdk.java.net/~lbourges/path2D/Path2D-8078192.2/ >>>> >>>> >>>> Changes: >>>> - trimToSize() return void >>>> - fixed test + jtreg passed >>>> >>>> Bye, >>>> Laurent >>>> >>>> 2017-04-20 21:30 GMT+02:00 Jim Graham >>>> >>> >: >>>> >>>> Hi Laurent, >>>> >>>> The implementation looks good, except that the >>>> method chaining-style return value seems out of >>>> place here. Similar trimToSize() methods in >>>> Collections return void and none of the other >>>> methods in this area use the method chaining >>>> paradigm. In the interest of maintaining a >>>> common design theme throughout 2D this method >>>> should just return void. >>>> >>>> ...jim >>>> >>>> >>>> On 4/18/17 11:49 PM, Laurent Bourg?s wrote: >>>> >>>> Hi, >>>> >>>> Here is a first attempt to propose a Path2D >>>> patch (based on JDK10): >>>> http://cr.openjdk.java.net/~lbourges/path2D/Path2D-8078192.0/ >>>> >>>> >>>> JBS: >>>> https://bugs.openjdk.java.net/browse/JDK-8078192 >>>> >>>> >>>> Please review the Path2D changes, notably >>>> the javadoc (english) and the modified >>>> Path2DCopyConstructor test which checks >>>> all public Path2D methods on concrete >>>> classes (Path2D.Float, Path2D.Double, >>>> GeneralPath) after calling path.trimToSize() >>>> >>>> Cheers, >>>> Laurent >>>> >>>> >>>> >>>> >>>> -- >>>> -- >>>> Laurent Bourg?s >>> >>> >>> >>> >>> -- >>> -- >>> Laurent Bourg?s >>> >>> >>> >>> >>> -- >>> -- >>> Laurent Bourg?s >> >> >> >> >> -- >> -- >> Laurent Bourg?s > From joe.darcy at oracle.com Mon Jun 12 20:25:24 2017 From: joe.darcy at oracle.com (Joseph D. Darcy) Date: Mon, 12 Jun 2017 13:25:24 -0700 Subject: Tracking what you have looked at .. In-Reply-To: <3e899036-d2a9-9226-1861-abb960fb173d@oracle.com> References: <7635e049-f41e-878c-2be2-7a1a66a25740@oracle.com> <3e899036-d2a9-9226-1861-abb960fb173d@oracle.com> Message-ID: <593EF8B4.6030400@oracle.com> On 5/31/2017 10:40 AM, Alan Bateman wrote: > On 31/05/2017 18:27, Phil Race wrote: > >> As the number of CSRs in process increases I am starting to realise that >> it is not so nice to track what I have looked at and OKed and also >> whether >> it was OKed for provisional or final. >> Adding yourself as a reviewer is non-specific >> Making a comment is not intimately tied to a state. >> >> I think we need some explicit fields that correspond to per-person >> and state. >> This may not be easy in JBS but that should not change its importance. > I think Joe said he has (or plan) to create a dashboards and/or > filters to help with this. > Hello, Starting to get caught up after a multi-week vacation. I do plan to create filters, dashboards, etc. in the near future and will send an update after some progress has been made. Thanks, -Joe From joe.darcy at oracle.com Mon Jun 12 21:09:19 2017 From: joe.darcy at oracle.com (Joseph D. Darcy) Date: Mon, 12 Jun 2017 14:09:19 -0700 Subject: Tracking what you have looked at .. In-Reply-To: <593EF8B4.6030400@oracle.com> References: <7635e049-f41e-878c-2be2-7a1a66a25740@oracle.com> <3e899036-d2a9-9226-1861-abb960fb173d@oracle.com> <593EF8B4.6030400@oracle.com> Message-ID: <593F02FF.9000305@oracle.com> PS Rudimentary dashboard up at https://bugs.openjdk.java.net/secure/Dashboard.jspa?selectPageId=17313 This is built around two JIRA filters jdk-csr-issues-under-review and jdk-csr-issues-pended. I expect this dashboard to evolve and change so its interface shouldn't be regarded as stable yet :-) Thanks, -Joe On 6/12/2017 1:25 PM, Joseph D. Darcy wrote: > On 5/31/2017 10:40 AM, Alan Bateman wrote: >> On 31/05/2017 18:27, Phil Race wrote: >> >>> As the number of CSRs in process increases I am starting to realise >>> that >>> it is not so nice to track what I have looked at and OKed and also >>> whether >>> it was OKed for provisional or final. >>> Adding yourself as a reviewer is non-specific >>> Making a comment is not intimately tied to a state. >>> >>> I think we need some explicit fields that correspond to per-person >>> and state. >>> This may not be easy in JBS but that should not change its importance. >> I think Joe said he has (or plan) to create a dashboards and/or >> filters to help with this. >> > > Hello, > > Starting to get caught up after a multi-week vacation. > > I do plan to create filters, dashboards, etc. in the near future and > will send an update after some progress has been made. > > Thanks, > > -Joe > From joe.darcy at oracle.com Tue Jun 13 01:02:29 2017 From: joe.darcy at oracle.com (joe darcy) Date: Mon, 12 Jun 2017 18:02:29 -0700 Subject: Expectations for CSR members and reviews Message-ID: Hello, Getting back from vacation, there are a few CSR topics to catch up on. First, thanks to Phil for adding some FAQ items in my absence; I'll expand the logistical FAQ items soon. Second, it is worthwhile to have some discussion about how CSR reviewers interact with the requests which come in. There are a number of ways CSR members can be involved with requests. First, a member can be one of the reviewers of a request and listed as such in the "Reviewed By:" field. After an engineer submits a CSR issue for review, by moving it to either of the Proposed or Finalized states, a CSR member has several options for further involvement. If a member notices a problem with the request, the member can move the request to the Pended state, providing a comment justifying doing so. Less serious problems can be brought up in comments and comments can also be used to ask questions or indicate the request looks fine. Other than the chair, CSR members are *not* expected to review each request that is submitted; although members are welcome to review any requests of interest and the chair may request other members to look over a particular request before the request is approved. For the past several years, the earlier ccc system which CSR is replacing received a high volume of incoming requests, on average more than one per calendar day. In years past, the ccc required numerous distinct roles to vote on a request before it could be approved. This proved unwieldy and introduced long latencies in the overall ccc review process for little benefit. For this reason, for many years there has been a more streamlined process where the chair is the primary reviewer with other reviewers focusing on particular areas, such as Phil reviewing client API requests. With the CSR system, I expect some adjustment to be made, but to preserve the overall reviewing model where each member is not expected to review each request before it is approved. Comments? Thanks, -Joe From Alan.Bateman at oracle.com Tue Jun 13 13:40:00 2017 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Tue, 13 Jun 2017 14:40:00 +0100 Subject: Expectations for CSR members and reviews In-Reply-To: References: Message-ID: On 13/06/2017 02:02, joe darcy wrote: > : > > There are a number of ways CSR members can be involved with requests. > First, a member can be one of the reviewers of a request and listed as > such in the "Reviewed By:" field. After an engineer submits a CSR > issue for review, by moving it to either of the Proposed or Finalized > states, a CSR member has several options for further involvement. If a > member notices a problem with the request, the member can move the > request to the Pended state, providing a comment justifying doing so. > Less serious problems can be brought up in comments and comments can > also be used to ask questions or indicate the request looks fine. > I've reviewed several CSRs and added myself to the list of reviewer once I was satisfied. Questions or clarifications already the way were via comments. Is that the right way to do this, particularly adding to the Reviewed-By list? -Alan From joe.darcy at oracle.com Tue Jun 13 15:43:05 2017 From: joe.darcy at oracle.com (joe darcy) Date: Tue, 13 Jun 2017 08:43:05 -0700 Subject: Expectations for CSR members and reviews In-Reply-To: References:

Message-ID: <68295fd3-08c2-6322-31d2-9e08fc505c9c@oracle.com> Hi Alan, On 6/13/2017 6:40 AM, Alan Bateman wrote: > On 13/06/2017 02:02, joe darcy wrote: >> : >> >> There are a number of ways CSR members can be involved with requests. >> First, a member can be one of the reviewers of a request and listed >> as such in the "Reviewed By:" field. After an engineer submits a CSR >> issue for review, by moving it to either of the Proposed or Finalized >> states, a CSR member has several options for further involvement. If >> a member notices a problem with the request, the member can move the >> request to the Pended state, providing a comment justifying doing so. >> Less serious problems can be brought up in comments and comments can >> also be used to ask questions or indicate the request looks fine. >> > I've reviewed several CSRs and added myself to the list of reviewer > once I was satisfied. Questions or clarifications already the way were > via comments. Is that the right way to do this, particularly adding to > the Reviewed-By list? > I think that is an appropriate use of the system. Thanks, -Joe From joe.darcy at oracle.com Wed Jun 21 00:48:03 2017 From: joe.darcy at oracle.com (joe darcy) Date: Tue, 20 Jun 2017 17:48:03 -0700 Subject: Tracking what you have looked at .. In-Reply-To: <593F02FF.9000305@oracle.com> References: <7635e049-f41e-878c-2be2-7a1a66a25740@oracle.com> <3e899036-d2a9-9226-1861-abb960fb173d@oracle.com> <593EF8B4.6030400@oracle.com> <593F02FF.9000305@oracle.com> Message-ID: <503f5444-dd5a-8ac8-7c71-334bf589de0e@oracle.com> PPS Slightly more informative version of the dashboard now up at the same URL. Separate tables for requests current under review, recently approved request (last 14 days), and pended requests. -Joe On 6/12/2017 2:09 PM, Joseph D. Darcy wrote: > PS Rudimentary dashboard up at > > https://bugs.openjdk.java.net/secure/Dashboard.jspa?selectPageId=17313 > > This is built around two JIRA filters jdk-csr-issues-under-review and > jdk-csr-issues-pended. > > I expect this dashboard to evolve and change so its interface > shouldn't be regarded as stable yet :-) > > Thanks, > > -Joe